Posted By
Csabo
on 2024-12-03
08:39:42
|  Re: Simple but nice BASIC code examples
Very nice, but can I complain a little bit? 
I looked at the code for the last one only and I'm... kinda disappointed that it's so sloppy. I'm not saying the "everything posted on Plus/4 World must be the best possible code!" or anything like that, but... Well, let me break it down:
- It's *full* of code that's not used! This is my biggest issue. The assignments to XR, XB, XA, YA, H, V are never used. This makes everything look more complicated and actually slows down the code quite a bit.
- The fact that the cases are mixed (line 10 is lowercase for some reason) just looks off
- "THEN:" is unnecessary and odd (the colon means there's "blank" instruction there). I'm surprised that even works!
- Once the extra code is removed, it's clear that the two separate IF statements in 60 and 65 simply should have been an IF/ELSE.
Here's my version, I did some minor optimization as well: any SIN/COS value that's used more than once is per-calculated.
1 REM LOXODROME
2 COLOR4,1:COLOR.,1:COLOR1,6,4:GRAPHIC1,1
3 B=-1.2:W=.006:D=.6:SD=SIN(D):CD=COS(D)
4 FORI=.TO80STEP.1:B=B+W*COS(B)
5 SB=SIN(B):CB=COS(B):CI=COS(I)*CB
6 X=160+120*SIN(I)*CB/1.25
7 Y=96*(1-SB*CD-CI*SD)
8 Z=SB*SD-CI*CD
9 IFZ>.THENDRAW1TOX,Y:ELSEDRAW1,X,Y
10 NEXT
The original runs for about 5:50, this one runs in about 2:40. About twice as fast, but produces an identical result. Further optimizations are still possible.
So... they are very nice, I'm happy to see them, and I don't expect "super optimized" code, but at least look over it once for such glaring issues  |
